-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Add ECS modules #132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarrien
force-pushed
the
mbarrien/ecs
branch
2 times, most recently
from
September 23, 2019 22:15
05784d7
to
13ba232
Compare
? |
ryanking
reviewed
Sep 23, 2019
Fixed PR description |
mbarrien
force-pushed
the
mbarrien/ecs
branch
2 times, most recently
from
September 24, 2019 15:39
8f64b7b
to
046205b
Compare
ryanking
suggested changes
Sep 24, 2019
mbarrien
force-pushed
the
mbarrien/ecs
branch
from
September 25, 2019 14:11
f943bd2
to
86e6950
Compare
Added untested support for awsvpc networking for non-Fargate jobs, via var.awsvpc_network_mode flag. Also added secrets manager for Docker image fetching. Note that using that flag also means that jobs using czecs would need to add networkMode and/or execution role to the definition. |
ryanking
changed the title
Add ECS modules to cztack
[feature] Add ECS modules to cztack
Sep 25, 2019
ryanking
approved these changes
Sep 25, 2019
mbarrien
changed the title
[feature] Add ECS modules to cztack
[feature] Add ECS modules
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds ECS service (public facing with a frontend) and ECS job (internal headless applications) modules to the public cztack repo, with separate modules for Fargate and non-Fargate jobs.
Changes relative to internal repo:
aws_lb_*
resources instead ofaws_alb_*
resourcesfargate_*
prefix since module is Fargate-specific.manage_task_definitions
instead of relying on a non-empty/non-null task_definition variable. This gets rid of the problem with "count cannot be determined from compute value" errors, but now requires the user to properly specify manage_task_definitions for their use case.