Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Benchmarking 'NoneType' object is not subscriptable error #289

Merged

Conversation

valenzuelaomar
Copy link
Contributor

@valenzuelaomar valenzuelaomar commented Aug 25, 2023

When cur is None, the function load_contig_lengths will fail when trying to index on the None type: cur[0], cur[1]. This fixes that issue by checking if the contigs assembly failed before computing contigs length

@valenzuelaomar valenzuelaomar requested a review from a team August 25, 2023 20:52
@valenzuelaomar valenzuelaomar changed the title [valenzuelaomar/fix-none-type-not-subscriptable-error] Fix Benchmarking 'NoneType' object is not subscriptable eorr Fix Benchmarking 'NoneType' object is not subscriptable erorr Aug 25, 2023
@valenzuelaomar valenzuelaomar changed the title Fix Benchmarking 'NoneType' object is not subscriptable erorr Fix Benchmarking 'NoneType' object is not subscriptable error Aug 25, 2023
Copy link
Collaborator

@rzlim08 rzlim08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@valenzuelaomar valenzuelaomar merged commit 50827d1 into main Aug 26, 2023
12 checks passed
@valenzuelaomar valenzuelaomar deleted the valenzuelaomar/fix-none-type-not-subscriptable-error branch August 26, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants