feat: Refactor <TablePageLayout> to support multiple tabs #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchu1
changed the title
bchu1
changed the title
bchu1
changed the title
|
Do we think people may have the |
ehoops-cz
reviewed
Jul 25, 2024
| return prev | ||
| }, | ||
| { replace: true }, | ||
| ) | ||
| } | ||
| }, [filteredCount, page, setSearchParams]) | ||
| }, [filteredCount, page, pageQueryParam, setSearchParams]) |
There was a problem hiding this comment.
It's confusing that page and pageQueryParam are two different things. Can we rename one?
tableTypeQueryParam? dataTypeQueryParam? 🤔
Definitely a good thing to keep in mind. Right now nothing on the runs page ever exceeds 1 page so we should be good. |
kne42
approved these changes
Jul 25, 2024
Comment on lines
55
to
62
| title={i18n.filterNoResultsFound} | ||
| description={i18n.filterTooRestrictive} | ||
| actions={<Button onClick={reset}>{i18n.clearFilters}</Button>} | ||
| /> | ||
| ), | ||
| filteredCount: filteredDatasetCount, | ||
| totalCount: datasetCount, | ||
| countLabel: i18n.datasets, |
There was a problem hiding this comment.
while you're here, would you mind updating to using useI18n()/t?
github-actions bot
added a commit
that referenced
this pull request
Jul 26, 2024
🤖 I have created a release *beep* *boop* --- ## [1.14.0](web-v1.13.1...web-v1.14.0) (2024-07-25) ### ✨ Features * Refactor <TablePageLayout> to support multiple tabs ([#911](#911)) ([659bea3](659bea3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#624
This is to support having both Annotations and Tomograms tabs on the Runs page.
<Tabs>component.pagetoannotations-page. In a subsequent PR I'll addtomograms-page.<Tabs>to take in components as labels andnumbers (i.e. indexes) as values.