fix: fix deploy var #514
Merged
fix: fix deploy var #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #514 +/- ##
=======================================
Coverage 96.06% 96.06%
=======================================
Files 8 8
Lines 661 661
=======================================
Hits 635 635
Misses 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
manasaV3
approved these changes
Feb 29, 2024
manasaV3
reviewed
Feb 29, 2024
There was a problem hiding this comment.
I believe this would need the gating variable to be defined in a different environment than what it is gating. Not blocking on that, but we should fix that in near future.
From async: we are using global variables for IS_DEPLOY_ALLOWED, so this concern is no longer valid.
kne42
added a commit
that referenced
this pull request
Feb 29, 2024
* main: chore: Fixing prod e2e test name (#519) chore: support more conventional commit types (#515) chore(main): release web 1.1.1 (#517) chore: add sh to readme (#518) fix: prod deploy tagging (#516) chore(main): release web 1.1.0 (#511) fix: fix deploy var (#514) feat: annotation table updates (#481) fix: Mapping samplings available to db field (#487) chore: fix release workflow (#508) feat: Update workflow for automating prod deploy (#471) chore(main): release cryoet-data-portal 1.0.1 (#506) fix: remove axios cache (#505) release changelog workflow (#476) E2E tests workflow (#473)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with prod deploy due to secrets not being available for job conditionals: actions/runner#520
This switches to using a repository variable which should be appropriate since the value can only be
trueorfalse