-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: address misc UI/UX bugs #1192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, thanks!
431ba28
to
4db5524
Compare
bd222ba
to
b3327c6
Compare
value: startCase(converter.toWords(i + 1)), | ||
})} | ||
label={ | ||
deposition.annotation_methods.length === 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - comment why 1
is the only value that's ignored
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
design wants if theres only one method for there not to be a "Method One" so we only ignore 1; if there's 0 it wont be executed at all and otherwise all values should display the header
return objectShapeTypes.map((value) => ({ value })) | ||
return objectShapeTypes.map((value) => ({ | ||
label: t( | ||
shapeTypeToI18nKey.get(value as ObjectShapeType) ?? ('' as I18nKeys), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does t('')
actually return? If it errors might be better to put it outside of the t()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, would prefer to do null check outside of t()
or use Record<ObjectShapeType, I18nKeys>
if undefined
is not possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah maybe ill make a util function for it
@@ -7,7 +7,7 @@ export type FeatureFlagEnvironment = typeof process.env.ENV | |||
export type FeatureFlagKey = 'depositions' | 'multipleTomograms' | |||
|
|||
export const FEATURE_FLAGS: Record<FeatureFlagKey, FeatureFlagEnvironment[]> = { | |||
depositions: ['local', 'dev'], | |||
depositions: ['local', 'dev', 'staging', 'prod'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
🤖 I have created a release *beep* *boop* --- ## [1.31.0](web-v1.30.0...web-v1.31.0) (2024-10-03) ### ✨ Features * Add portal standard badge to tomograms table and integrate alignment metadata accordion with new API ([#1179](#1179)) ([1de70a1](1de70a1)) * Add standard tomogram badge to tomogram selector ([#1181](#1181)) ([ac4ad27](ac4ad27)) * Add tooltip to Alignment ID field in tomogram sidebar ([#1196](#1196)) ([fad5207](fad5207)) * Integrate more V2 API queries ([#1174](#1174)) ([92f80a7](92f80a7)) * Migrate and start using tomograms query in UI ([#1169](#1169)) ([d21ffd9](d21ffd9)) * Undo changes for transforming annotations and add new callout for mismatched alignments ([#1191](#1191)) ([ea1598d](ea1598d)) * update annotation row name ([#1163](#1163)) ([6164201](6164201)) * Update to generic annotation transformation callout during download ([#1186](#1186)) ([5597524](5597524)) ### 🐞 Bug Fixes * address misc UI/UX bugs ([#1192](#1192)) ([178737d](178737d)) * change incorrect deposition links ([#1133](#1133)) ([dc642e5](dc642e5)) * Stop querying depositionTitle ([#1187](#1187)) ([07a08d4](07a08d4)) ### 🧹 Miscellaneous Chores * prefix IDs across the portal ([#1178](#1178)) ([1732fb2](1732fb2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
see https://docs.google.com/document/d/1jJ56MqvTCBGKbj7XOpdhvGH20MYF0F_ndG2T5jOWQsw/edit?usp=sharing