-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add filter panel to single deposition page #1030
Conversation
import { gql } from 'app/__generated__' | ||
import { Datasets_Bool_Exp } from 'app/__generated__/graphql' | ||
|
||
const GET_DATASETS_FILTER_DATA_QUERY = gql(` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to just make this a fragment? https://www.apollographql.com/docs/react/data/fragments/ That way any query can add this just by concatenating the string. It should generate the type too, hopefully that would work with useTypedLoaderData()
?
const TEST_FRAGMENT = gql(`
fragment TestFragment on query_root {
datasets {
organism_name
}
}
`)
useTypedLoaderData<TestFragmentFragment>()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes i think so. a lot of the codebase could actually benefit from fragments (for example authors)
how important do you think this is? since i have low bandwidth i would prefer to keep this as-is and make the refactor along with the other places we should be using fragments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's too important! Maybe file a ticket?
* main: (21 commits) feat: add filter panel to single deposition page (#1030) chore(main): release web 1.21.0 (#1032) feat: Update Tomogram Processing field format and query (#1031) chore(main): release web 1.20.0 (#1028) feat: Implement collapsing Annotated Objects list (#1024) chore: Add e2e test for errors on Neuroglancer site (#1027) chore(main): release web 1.19.1 (#1023) fix: Fix Neuroglancer URL bug (#1026) fix: Dedupe authors (#1018) chore(main): release web 1.19.0 (#1019) refactor: download dialog tests (#1011) feat: Add Tomograms table (#988) feat: Enable pagination of Annotations table with temporary hacky query (#992) chore(main): release web 1.18.0 (#984) feat: Add Tomograms tab to Run page (#983) chore: remove extra GHA concurrency lock from prod-deploy.yml (#982) feat: add user agent to client requests (#966) chore: Add additional test case to TestGetDestinationPath (#955) chore(main): release web 1.17.0 (#971) ci: update frontend release pr filter (#977) ...
🤖 I have created a release *beep* *boop* --- ## [1.22.0](web-v1.21.0...web-v1.22.0) (2024-08-16) ### ✨ Features * add filter panel to single deposition page ([#1030](#1030)) ([d378e7c](d378e7c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
#923
note that applying filters will not filter the results until #920 and will merely update the search params