Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add additional test case to TestGetDestinationPath #955

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

Bento007
Copy link
Contributor

  • add test test_dest_path_is_existing_file
  • remove unused test code.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.99%. Comparing base (958b553) to head (38f9af5).
Report is 120 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #955      +/-   ##
==========================================
+ Coverage   96.06%   96.99%   +0.93%     
==========================================
  Files           8       10       +2     
  Lines         661      766     +105     
==========================================
+ Hits          635      743     +108     
+ Misses         26       23       -3     
Flag Coverage Δ
unittests 96.99% <100.00%> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bento007 Bento007 requested a review from manasaV3 July 31, 2024 17:19
@Bento007 Bento007 merged commit a9412a8 into main Aug 1, 2024
17 checks passed
@Bento007 Bento007 deleted the tsmith/887-default branch August 1, 2024 20:21
kne42 added a commit that referenced this pull request Aug 16, 2024
* main: (21 commits)
  feat: add filter panel to single deposition page (#1030)
  chore(main): release web 1.21.0 (#1032)
  feat: Update Tomogram Processing field format and query (#1031)
  chore(main): release web 1.20.0 (#1028)
  feat: Implement collapsing Annotated Objects list (#1024)
  chore: Add e2e test for errors on Neuroglancer site (#1027)
  chore(main): release web 1.19.1 (#1023)
  fix: Fix Neuroglancer URL bug (#1026)
  fix: Dedupe authors (#1018)
  chore(main): release web 1.19.0 (#1019)
  refactor: download dialog tests (#1011)
  feat: Add Tomograms table (#988)
  feat: Enable pagination of Annotations table with temporary hacky query (#992)
  chore(main): release web 1.18.0 (#984)
  feat: Add Tomograms tab to Run page (#983)
  chore: remove extra GHA concurrency lock from prod-deploy.yml (#982)
  feat: add user agent to client requests (#966)
  chore: Add additional test case to TestGetDestinationPath (#955)
  chore(main): release web 1.17.0 (#971)
  ci: update frontend release pr filter (#977)
  ...
Bento007 pushed a commit that referenced this pull request Aug 22, 2024
🤖 I have created a release *beep* *boop*
---


##
[3.1.0](cryoet-data-portal-python-client-v3.0.3...cryoet-data-portal-python-client-v3.1.0)
(2024-08-22)


### ✨ Features

* add user agent to client requests
([#966](#966))
([8209cd4](8209cd4))
* Generate Python client code using GraphQL introspection
([#1008](#1008))
([35b7265](35b7265))


### 🐞 Bug Fixes

* create recursive_from_prefix path if it does not exist
([#940](#940))
([0069f08](0069f08))
* Use match with substring for exception check in client tests
([#895](#895))
([07352ec](07352ec))
* wait for graphql to be healthy in client tests
([#1044](#1044))
([65f0a4b](65f0a4b)),
closes
[#942](#942)


### 🧹 Miscellaneous Chores

* Add additional test case to TestGetDestinationPath
([#955](#955))
([a9412a8](a9412a8))
* add instructions and commands to manually release the python package.
([#1073](#1073))
([4833eb9](4833eb9))
* automate release of python client
([#972](#972))
([073bff7](073bff7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants