Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter on browse all data page #25

Closed
5 tasks
Tracked by #24
junxini opened this issue Sep 27, 2023 · 3 comments
Closed
5 tasks
Tracked by #24

Filter on browse all data page #25

junxini opened this issue Sep 27, 2023 · 3 comments
Assignees
Labels
P0 Must have website

Comments

@junxini
Copy link
Contributor

junxini commented Sep 27, 2023

User Story: 2.2 I want to filter through the data, so that I can narrow down my selection

  • 13 filters total, organized within 7 groups (see design)
  • general AND/OR logic:
    • AND logic between different filters (e.g., I want to see object name = ribosome AND camera manufacturer = Gatan)
    • OR logic for multiple values within one filter (e.g., I want to see datasets that have Ribosomes OR Membranes annotated)
    • exception to the above rule: multi-select under the "available files" section is AND logic (e.g., i want to see datasets where it includes raw frames AND tilt series)
  • when filter is applied, show as a blue tag that use can "X" out of to remove
  • only show the filter values that we have available in the database (i.e., we wouldn't list "Mesh" under object shape type if it doesn't exist in our metadata)
  • once filter is applied, show number of search results in the dataset table
  • note: see specific filter menu types in design

Link to design: https://www.figma.com/file/WEmbsjtlBUtRy7pzmuCCjj/CryoET-Data-Portal---Phase-2-Designs?type=design&node-id=1637-37001&mode=design&t=QGhDNstOreaiFP49-0

@junxini junxini added the P0 Must have label Sep 27, 2023
@manasaV3 manasaV3 changed the title Filter through data Filter search page results Sep 27, 2023
@junxini junxini added the website label Nov 6, 2023
@junxini junxini changed the title Filter search page results Filter on browse all data page Nov 6, 2023
@Janeece
Copy link
Collaborator

Janeece commented Nov 13, 2023

Screenshot from Design (for quick reference):

Image

@lauramarcos
Copy link
Collaborator

lauramarcos commented Nov 24, 2023

Following bugs were found during this testing:

Ground Truth Annotation filter is not in correct format and has no hover state #171

None of the filters remains shadowed at click and arrow doesn't turn blue as in design #172

"Results must include all selected file types:" is missing in [Available Files] dropdown filter #173

Check symbol next to text in all filter dropdowns are not centered with text #174

[staging] Application Error page when applying any filter #185

"Meets all:" label is missing under Available Files filter #186

"AND" login in "Included Contents" filters is not working as expected #190

"Limit one value per field" instead than "Limit one value per input" in Author filter #191

"Author ORCID:" instead of "Author ORCID ID:" in Author filter #192

Header objects move and scroll bar disappear when applying some filters #200

"OR" logic seems not to be working in Name/ID filters #205

button is enabled in Tilt Range filter when it should be disabled #208

"≤ Filter Range ≤" label in Tilt Range filter is not centered in dropdown #209

No hover state in blue tag for Tilt Range filter #210

Blue tag [0 - 0] shows up when deleting existent blue tag in Tilt Range filter #211

Negative values and more than three digit values can be inserted in Tilt Range filters #212

Empty field in Reconstruction Method filter #213

@lauramarcos
Copy link
Collaborator

Passing this item to Completed as bugs opened are taking care of already, no need to track this one here, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Must have website
Projects
None yet
Development

No branches or pull requests

4 participants