Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty field in Reconstruction Method filter #213

Closed
lauramarcos opened this issue Dec 5, 2023 · 6 comments
Closed

Empty field in Reconstruction Method filter #213

lauramarcos opened this issue Dec 5, 2023 · 6 comments
Assignees
Labels
backend bug Something isn't working severity - low little impact to the overall functionality of the Portal (e.g., wrong sized button) website

Comments

@lauramarcos
Copy link
Collaborator

Steps to Reproduce

  1. Locate [Reconstruction Method] filter
  2. Click on [Reconstruction Method] filter
  3. Hover on top of first option on dropdown
  4. Pay attention to shadowed area

Actual Results
Seems to be an empty field in dropdown

Expected Results
There should not be empty fields in dropdown

Evidence

Screen.Recording.2023-12-05.at.3.04.31.PM.mov
@lauramarcos lauramarcos added bug Something isn't working website frontend labels Dec 5, 2023
@junxini junxini added the severity - low little impact to the overall functionality of the Portal (e.g., wrong sized button) label Dec 9, 2023
@manasaV3
Copy link
Contributor

manasaV3 commented Jan 9, 2024

Set reconstruction method for dataset id= 10005 to be None.

@manasaV3 manasaV3 added backend and removed frontend labels Jan 9, 2024
@manasaV3
Copy link
Contributor

manasaV3 commented Jan 9, 2024

Also add constraints to the reconstruction method field to not be empty.

@junxini junxini assigned manasaV3 and unassigned codemonkey800 Jan 10, 2024
@manasaV3
Copy link
Contributor

@anchi2c I noticed datasets 10023 and 10024 also have a few runs with an empty string value for reconstruction method.

This is because the related gjensen datasets (id=33, 34 in file 068.json) have an empty map as value for the tomograms key. How should we handle those?

@anchi2c
Copy link

anchi2c commented Jan 23, 2024

I default reconstruction method to "Wighted back projection" and correct bugs that gave multiple reconstruction methods and reconstruction software. in the latest zii-data-portal-processing revision https://github.com/czimaginginstitute/czii-data-portal-processing/commit/c95da43abfc0150128c0551f20f8ef07fd1e7b53

All json files were updated in this revision affect all tomogram metadata.

@anchi2c
Copy link

anchi2c commented Jan 23, 2024

@manasaV3 these json are ready for you to process.

@lauramarcos lauramarcos changed the title [staging] Empty field in Reconstruction Method filter Empty field in Reconstruction Method filter Feb 21, 2024
@manasaV3 manasaV3 added this to the sprint 4 (phase 3) milestone Mar 4, 2024
@manasaV3 manasaV3 closed this as completed Apr 9, 2024
@manasaV3
Copy link
Contributor

manasaV3 commented Apr 9, 2024

Screenshot 2024-04-08 at 11 21 48 PM

The bug has been fixed in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working severity - low little impact to the overall functionality of the Portal (e.g., wrong sized button) website
Projects
None yet
Development

No branches or pull requests

5 participants