Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download single annotation dialog updates + BE integration #1046

Closed
Tracked by #624
junxini opened this issue Aug 20, 2024 · 1 comment
Closed
Tracked by #624

Download single annotation dialog updates + BE integration #1046

junxini opened this issue Aug 20, 2024 · 1 comment
Assignees
@bchu1
Labels
frontend P0 Must have
Milestone
sprint 4 (phase 4)

Comments

@junxini
Copy link
Contributor

junxini commented Aug 20, 2024 •
edited
Loading

https://www.figma.com/design/RsjklVi95DFKatU4Uzi2OG/Janeece---Multiple-Tomograms?node-id=582-18677&t=JVNohTLfE5DZjUsE-0
@junxini junxini mentioned this issue Aug 20, 2024
Open
19 tasks
@junxini junxini added frontend P0 Must have labels Aug 22, 2024
@junxini
Copy link
Contributor Author

junxini commented Aug 22, 2024

hold off for after design handoff

@bchu1 bchu1 changed the title Download single annotation dialog updates Download single annotation dialog updates + BE integration Sep 3, 2024
@bchu1 bchu1 added this to the sprint 4 (phase 4) milestone Sep 5, 2024
@bchu1 bchu1 mentioned this issue Sep 13, 2024
Merged
bchu1 added a commit that referenced this issue Sep 19, 2024
@bchu1
feat: Add reference tomogram selector for single annotation download (#…
d1f694a 
…1136)

#1046 

- Refactors the tomogram selectors into a separate directory +
component.
- Makes the widths of all `<Select>` dropdown menus match the width of
the input element.
- Adds disabled tabs + tooltips (not hooked up to `is_portal_standard`
yet).
 - Adds new Portal CLI label, but not the actual tab content.
- Renames some property names in the download modal context for clarity.
- Adds a `checkExhaustive()` util function for guaranteeing that
switches check all possible values.


https://github.com/user-attachments/assets/f6a21d0e-ed18-4cc1-b3be-593b0d25da64
This was referenced Sep 27, 2024
Merged
Merged
bchu1 added a commit that referenced this issue Sep 30, 2024
@bchu1
feat: Update to generic annotation transformation callout during down…
5597524 
…load (#1186)

#1005
#1045 
#1046 

This change is being made because we are no longer providing specific
transformation code when annotations are used with non-standard
tomograms.

This also adds a 15 second `sleep` before running tests so that the app
server has time to start (`ERR_CONNECTION_REFUSED`).
@bchu1 bchu1 closed this as completed Sep 30, 2024
bchu1 added a commit that referenced this issue Oct 1, 2024
@bchu1
feat: Undo changes for transforming annotations and add new callout f…
ea1598d 
…or mismatched alignments (#1191)

#1046

Transforming annotations is now out of scope.

Alignment of annotation has not been integrated with the BE yet, since
that requires migrating the entire annotations query.

<img width="684" alt="image"
src="https://github.com/user-attachments/assets/c613c6f5-c496-4e19-aab8-901c2a8efb73">

<img width="694" alt="image"
src="https://github.com/user-attachments/assets/3458a9eb-8b6c-41a6-9fa4-5097d0ab5062">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bchu1 bchu1

Labels
frontend P0 Must have
Projects
None yet
Milestone
sprint 4 (phase 4)
Development

No branches or pull requests
2 participants
@junxini @bchu1