Skip to content

Commit

Permalink
chore: Leave comments about not refactoring pagination tests (#1121)
Browse files Browse the repository at this point in the history
Relates to #963 

We decided to deprioritize refactoring the pagination tests since we do
not anticipate needing updates soon. This PR adds a comment to the two
pagination related test files indicating that future devs should follow
the page object model instead.
  • Loading branch information
ehoops-cz authored Sep 9, 2024
1 parent 5d549dc commit fafac8a
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
5 changes: 5 additions & 0 deletions frontend/packages/data-portal/e2e/pagination.test.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
/*
* NOTE: This file does not use the preferred page object pattern.
* This is because we did not have time to refactor.
* Please do not use this file as an example of how to write tests.
*/
import { TableValidatorOptions } from 'e2e/pageObjects/filters/types'

import { MAX_PER_PAGE } from 'app/constants/pagination'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
/*
* NOTE: This file does not use the preferred page object pattern.
* This is because we did not have time to refactor.
* Please do not use this file as an example of how to write tests.
*/
import { expect, Page, test } from '@playwright/test'
import { getApolloClient } from 'e2e/apollo'
import { E2E_CONFIG } from 'e2e/constants'
Expand Down

0 comments on commit fafac8a

Please sign in to comment.