fix: Updating ingestor to use amd #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manasaV3
force-pushed
the
mvenkatakrishnan/ingestor_validation
branch
from
2001bd3
to
98955e6
Compare
|
Does this need to be updated or does it actually work ok? |
The image built fine for amd with that config. I was able to validate in the image that imod commands were runnable. |
manasaV3
changed the title
jgadling
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making changes to revert the ingestor image to be built on
linux/amdplatform as there isn't sufficient support to use IMOD on the arm platform at the moment.Having the ingestor be a part of the docker-compose file used for building api-server causes build issues, so moving it to a separate docker config.