Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove similarity search notebook #1252

Closed
wants to merge 2 commits into from

Conversation

ebezzi
Copy link
Member

@ebezzi ebezzi commented Jul 29, 2024

This notebook isn't ready for the docsite yet.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.26%. Comparing base (eb8f449) to head (28cf56b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1252   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files          80       80           
  Lines        6329     6329           
=======================================
  Hits         5776     5776           
  Misses        553      553           
Flag Coverage Δ
unittests 91.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ivirshup ivirshup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would also need to be removed from docs/examples.rst:30

Would it make sense to just revert and reopen the PR that added this? It would also be good to make sure that re-adding this was tracked for the next release.

cc: @pablo-gar

@ebezzi
Copy link
Member Author

ebezzi commented Jul 29, 2024

I think this would also need to be removed from docs/examples.rst:30

Would it make sense to just revert and reopen the PR that added this? It would also be good to make sure that re-adding this was tracked for the next release.

cc: @pablo-gar

Thanks, forgot about that.

I think it makes sense to keep the notebook if we don't link it in the docsite.

@ivirshup
Copy link
Collaborator

As discussed in person, we can probably do a doc build from this PR and not need to re-add things later.

@ebezzi
Copy link
Member Author

ebezzi commented Aug 1, 2024

Closing this - the branch was enough for patching the docsite.

@ebezzi ebezzi closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants