Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin census release version used in test #1237

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

ivirshup
Copy link
Collaborator

@ivirshup ivirshup commented Jul 11, 2024

https://github.com/chanzuckerberg/cellxgene-census/actions/runs/9882376259/job/27295103088

The test failure on the full tests is due to the new LTS. The test uses both value_filter and coords on stable, but now that ends selecting 0 cells. I think we should probably just pin this test to a specific LTS release.

census["census_data"]["mus_musculus"].axis_query(
    measurement_name="RNA",
    obs_query=tiledbsoma.AxisQuery(value_filter="is_primary_data == True", coords=(slice(750_000, 1_000_000),)),
).to_anndata(X_name="raw").shape
# (0, 52437)

Starting another test run on this branch: https://github.com/chanzuckerberg/cellxgene-census/actions/runs/9899971112

@ivirshup ivirshup changed the title Pin soma version used in test Pin census release version used in test Jul 11, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.26%. Comparing base (3d1162b) to head (b91242a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1237   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files          80       80           
  Lines        6330     6330           
=======================================
  Hits         5777     5777           
  Misses        553      553           
Flag Coverage Δ
unittests 91.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivirshup ivirshup merged commit 5cbad99 into main Jul 12, 2024
15 checks passed
@ivirshup ivirshup deleted the ivirshup/pin-lts-for-hvg-tests branch July 12, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants