Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Relax pin: tiledbsoma~=1.11.4 #1187

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

ryan-williams
Copy link
Contributor

@ryan-williams ryan-williams commented Jun 6, 2024

While developing, local tiledbsoma installs get version numbers like 1.11.4.post0.dev3991933300. The tiledbsoma==1.11.4 pin in this repo errors when attempting to install alongside such a tiledbsoma, e.g. in arrayloader-benchmarks:

pip install -e cellxgene-census/api/python/cellxgene_census -e tiledb-soma/apis/python
# ERROR: Cannot install cellxgene-census==1.14.2.dev3+g5de4536.d20240606 and tiledbsoma 1.11.4.post0.dev3991933300 (from $PWD/tiledb-soma/apis/python) because these package versions have conflicting dependencies.
# 
# The conflict is caused by:
#     The user requested tiledbsoma 1.11.4.post0.dev3991933300 (from $PWD/tiledb-soma/apis/python)
#     cellxgene-census 1.14.2.dev3+g5de4536.d20240606 depends on tiledbsoma==1.11.4
# 
# To fix this you could try to:
# 1. loosen the range of package versions you've specified
# 2. remove package versions to allow pip attempt to solve the dependency conflict

tiledbsoma~=1.11.4 (equivalent to tiledbsoma>=1.11.4,<1.12.0) lets such local installs work, and doesn't have any downsides, afaict.

(factored out of #1169)

Copy link
Member

@ebezzi ebezzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, the == was introduced by mistake in the last release. Thanks Ryan!

@ryan-williams
Copy link
Contributor Author

Ah gtk, I hadn't noticed that (dfb2042).

The Docker build GHA here failed with:

ERROR: invalid tag "/cellxgene-census-builder:823a27f": invalid reference format

after checking out SHA 823a27f ("Merge 5de4536 into 5fc72e2").

I'm guessing the issue is that I opened this PR from a branch in my fork. lmk if you want me to open a new one from a branch in this repo, or take some other action?

@ebezzi
Copy link
Member

ebezzi commented Jun 6, 2024

Ah gtk, I hadn't noticed that (dfb2042).

The Docker build GHA here failed with:

ERROR: invalid tag "/cellxgene-census-builder:823a27f": invalid reference format

after checking out SHA 823a27f ("Merge 5de4536 into 5fc72e2").

I'm guessing the issue is that I opened this PR from a branch in my fork. lmk if you want me to open a new one from a branch in this repo, or take some other action?

Yeah, that's a known issue. I will go ahead and merge this. Thanks again!

@ebezzi ebezzi merged commit ef62987 into chanzuckerberg:main Jun 6, 2024
11 of 12 checks passed
@ryan-williams ryan-williams deleted the tdbs-pin branch June 6, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants