Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserting empty array and document into boolean field #89

Closed
yaziine opened this issue Jun 1, 2020 · 2 comments · Fixed by #98
Closed

Inserting empty array and document into boolean field #89

yaziine opened this issue Jun 1, 2020 · 2 comments · Fixed by #98
Assignees
Labels
bug Something isn't working
Milestone

Comments

@yaziine
Copy link
Collaborator

yaziine commented Jun 1, 2020

If I insert an empty array or an empty document into a boolean field, I would expect that the value of that field will be false. Exactly the same way as with empty strings.

What do you think?

genji> CREATE TABLE test(a bool, b bool, c bool);
genji> INSERT INTO test VALUES {a: "", b: [], c: {}};
genji> SELECT * FROM test;
{
  "a": false,
  "b": true,
  "c": true
}
@asdine
Copy link
Collaborator

asdine commented Jun 1, 2020

Probably an error in their zero value in the document package

@asdine asdine added the bug Something isn't working label Jun 1, 2020
@yaziine yaziine added this to the v0.6.0 milestone Jun 1, 2020
@yaziine
Copy link
Collaborator Author

yaziine commented Jun 1, 2020

I've added this for the current milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants