Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for context.Context #206

Closed
asdine opened this issue Sep 27, 2020 · 0 comments · Fixed by #221
Closed

Add support for context.Context #206

asdine opened this issue Sep 27, 2020 · 0 comments · Fixed by #221
Labels
core Low level packages
Milestone
v0.9.0

Comments

@asdine
Copy link
Collaborator

asdine commented Sep 27, 2020

Currently, while there is a way of stopping SELECT queries by simply stopping the iteration on the stream, there is no way of halting INSERT, UPDATES and DELETES. When we'll add subqueries, it will be even more important.

We should change the api to pass context.Context everywhere it is necessary.
@asdine asdine added the core Low level packages label Sep 27, 2020
@asdine asdine added this to the v0.9.0 milestone Sep 27, 2020
@asdine asdine mentioned this issue Oct 4, 2020
Merged
This was referenced Oct 5, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Low level packages
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

Add support for context chaisql/chai
1 participant
@asdine