Add kyb to kyc verified check, add tests, update caminogo dependency #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evlekht
force-pushed
the
cortina-15/cortina-cleanup
branch
from
d6c0b14
to
9358a7e
Compare
evlekht
changed the base branch from
cortina-15/cortina-cleanup
to
cortina-15/base
evlekht
changed the title
evlekht
changed the title
evlekht
changed the base branch from
cortina-15/base
to
cortina-15/cortina-cleanup
mo-c4t
previously approved these changes
Jul 25, 2024
havan
previously approved these changes
Jul 25, 2024
evlekht
force-pushed
the
cortina-15/cortina-cleanup
branch
2 times, most recently
from
bfee1fe
to
890c315
Compare
evlekht
dismissed stale reviews from havan and mo-c4t
The base branch was changed.
evlekht
changed the title
havan
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR adds KYB address state bit and changes admin controller to use KYB or KYC instead of KYC only.
PR also adds unit test for admin controller KycVerified method and updates caminogo dependency.
How this was tested
With newly added unit test and with manual testing.
Additional references
Original PR based on cortina-19 dev
#101