Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise ScreenAlignedTriangle and ScreenAlignedQuad (again) #402

Open
j-o opened this issue Aug 22, 2017 · 0 comments
Open

Revise ScreenAlignedTriangle and ScreenAlignedQuad (again) #402

j-o opened this issue Aug 22, 2017 · 0 comments

Comments

@j-o
Copy link
Contributor

j-o commented Aug 22, 2017

Typically, a screen-aligned quad/triangle is used to do post-processing using shaders; however, the current implementations of ScreenAlignedTriangle and ScreenAlignedQuad do not allow this: they simply display an existing texture. This should be reflected in the class name to avoid confusion.

Further, since their functionality is reduced to displaying an existing texture, they are pretty much identical, so what is the point of having both?

I would suggest to replace the current ScreenAlignedTriangle and ScreenAlignedQuad classes with:

  • A (single) TextureDisplay (or similar) class that displays an existing texture on screen
  • A screen-aligned triangle geometry class (the current Triangle is not screen-aligned)
  • A screen-aligned quad geometry class (the current Quad can be used with size = 2)

The latter might not be required if a screen-aligned triangle is considered state-of-the-art, making the screen-aligned quad obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant