Sync from fork #74

0xmuralik · 2023-01-05T12:05:19Z

Closes: #72

Description

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

* imp: migrate JSON for feemarket * migrate JSON * types * fix * fix unmarshal JSON error * changelog * fix lint * fix test

* fix: update feemarket REST endpoints * changelog

* x/evm - PostTxProcessing use message as callback input * Update CHANGELOG.md * Use core.Message for the PostTxProcessing hook (PR review)

* fix lint workflow * fix comment * remove format * change checkout with setup-go * update comment * add checkout * add lint issue * revert lint error

Closes: #946 Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* add log after tx post processing hook add changelog fix tests rename variable minimum change version * Update x/evm/keeper/state_transition.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

…onflict (#1023) with existing types Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 2.1.0 to 3. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-action@v2.1.0...v3) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add ValidateNonZeroAddress validation utility * Update types/validation.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

Bumps [actions/stale](https://github.com/actions/stale) from 4 to 5. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v4...v5) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump actions/setup-go from 2 to 3 Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2 to 3. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v2...v3) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Apply suggestions from code review Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* release: v0.13.0 (#1030) * release: v0.12.0 changelog * changelog: v0.12.1 (#1019) * evm: update empty hash check for storage state (#1016) * v0.12.1: changelog * changelog: v0.12.2 (#1022) * changelog: v0.12.2 * fix * fix * update changelog * deps: bump SDK to v0.45.3 * changelog * fixes

* tests: Add tests for MsgEthereumTx getter methods * tests: Add nil data test for MsgEthereumTx buildTx * tests: Removed unnecessary sdk>big.Int conversions in MsgEthereumTx ValidateBasic test * tests: Replace deprecated ethtypes.NewTransaction * tests: Add AccessListTx tests * tests: Fix dropped LegacyTx coverage * Address PR comments Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-ANSIREGEX-1583908 Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

…ties (#1039) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NODEFETCH-2342118 Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

…ties (#1038) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NODEFETCH-2342118 Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* use SimAppChainId instead of the default cosmos-sdk simulation chainid * implement custom RandomGenesisAccounts for auth module simulation * use customized RandomGenesisAccounts * generate random ethereum txs operations * use sdk.DefaultBondDenom * implement WeightedOperations * fix self assignment * use customized RandomAccounts to generate accounts with ethsecp256k1 private key * RandomAccounts generate random accounts with ethsecp256k1 private key * implement SimulateEthSimpleTransfer * implement SimulateEthCreateContract * refactor and implement operationSimulateEthCallContract as future operations of SimulateEthCreateContract * Update app/app.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * Update app/test_helpers.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * Update x/evm/simulation/operations.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * Update x/evm/simulation/operations.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * Update app/test_helpers.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * fix r.Read return only 1 result * fix linter errors * change SimulateContext to private * return transferable amount immediately * fix linter errors * fix linter errors: append assign to different slice * fix linter error: remove else block * use gofumpt * Update x/evm/simulation/operations.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * Update x/evm/simulation/operations.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * Update x/evm/simulation/operations.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * Update x/evm/simulation/operations.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * fix recipient typo * add nosec comment to escape Potential hardcoded credentials check * add comments * use SimAppChainID as valid chainID * do not specify genesis.json to create random genesis state for simulation * sub estimateGas to avoid overflow * correct RandomGenesisAccounts comments Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * correct app/test_helpers.go comments Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * remove NewTxConfig * implement RegisterStoreDecoder * remove WeightMsgEthCallContract and adjust weights * use gofmt * update godoc * use types.DefaultEVMDenom in evm genesis params Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * use types.DefaultEVMDenom Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * update godoc * Update x/evm/simulation/genesis.go * replace evmdenom with bonddenom in AppStateFn * fix AppStateFn * fix lint error * add ParamChanges for RandomizedParams * rename app/test_helpers.go -> app/utils.go * testing for RandomGenesisAccounts * use cdc for marshaling * lint * changelog * changelog 2 Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: crypto-facs <84574577+crypto-facs@users.noreply.github.com> Co-authored-by: Freddy Caceres <freddy.caceres@crypto.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>

* make jsonrpc api namespaces extensible Closes: #1052, #1037 * Apply suggestions from code review Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

…(#1065) Bumps [github.com/cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) from 0.45.3 to 0.45.4. - [Release notes](https://github.com/cosmos/cosmos-sdk/releases) - [Changelog](https://github.com/cosmos/cosmos-sdk/blob/v0.45.4/CHANGELOG.md) - [Commits](cosmos/cosmos-sdk@v0.45.3...v0.45.4) --- updated-dependencies: - dependency-name: github.com/cosmos/cosmos-sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 to 2. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v1...v2) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* release: v0.14.0 changelog (#1057) * fix: update BaseFee JSON-RPC * typo * changelog

… (#1069)

codecov-commenter · 2023-01-06T06:41:52Z

Codecov Report

Merging #74 (51aa603) into main (fac5a95) will increase coverage by 8.12%.
The diff coverage is 68.96%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   58.44%   66.57%   +8.12%     
==========================================
  Files         142      145       +3     
  Lines       15644    15953     +309     
==========================================
+ Hits         9143    10620    +1477     
+ Misses       6147     4859    -1288     
- Partials      354      474     +120

Impacted Files	Coverage Δ
indexer/kv_indexer.go	`64.96% <0.00%> (ø)`
rpc/backend/backend.go	`76.47% <ø> (+29.80%)`	⬆️
rpc/backend/filters.go	`100.00% <ø> (+100.00%)`	⬆️
rpc/backend/node_info.go	`46.51% <0.00%> (+46.51%)`	⬆️
rpc/types/events.go	`71.85% <ø> (ø)`
rpc/types/utils.go	`0.00% <0.00%> (ø)`
types/chain_id.go	`84.21% <ø> (ø)`
types/int.go	`41.66% <ø> (ø)`
types/validation.go	`100.00% <ø> (ø)`
x/auction/client/testutil/common.go	`100.00% <ø> (ø)`
... and 74 more

0xmuralik · 2023-01-06T10:49:38Z

Failing tests:
Protobuf: just a warning to indicate changes in proto files
Semgrep: mutex lock released in cleanup func. This warning can be ignored.
Dependecy review: few import in ethermint contain vulnerabilities.

i-norden

LGTM! I appreciate the quick turn around on such a large rebase/refactor. And thanks for explaining the failing actions, that all checks out, the flagged JS is only being used in solidity test suites so I'm not worried about that. We should still come back and tidy this up in a separate issue.

fedekunze and others added 30 commits March 29, 2022 12:57

evm: update empty hash check for storage state (#1016)

285c7c4

imp: migrate JSON for feemarket (#1021)

3c8a95b

* imp: migrate JSON for feemarket * migrate JSON * types * fix * fix unmarshal JSON error * changelog * fix lint * fix test

fix: update feemarket REST endpoints (#1026)

6abe84b

* fix: update feemarket REST endpoints * changelog

evm: PostTxProcessing hook - include the full message data (#1027)

cc37ed2

* x/evm - PostTxProcessing use message as callback input * Update CHANGELOG.md * Use core.Message for the PostTxProcessing hook (PR review)

fix: lint workflow (#1028)

8202a09

* fix lint workflow * fix comment * remove format * change checkout with setup-go * update comment * add checkout * add lint issue * revert lint error

deps: upgrade cosmos-sdk to v0.45.2 (#1029)

7d11c93

Closes: #946 Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

fix: remove proto message registration from legacy v09 types to fix c…

ea3c16e

…onflict (#1023) with existing types Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

tests: add more dynamic fee tx tests (#1032)

c70701e

types: add ValidateNonZeroAddress utility function (#1033)

e1512c5

* Add ValidateNonZeroAddress validation utility * Update types/validation.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

ci: cleanup (#1048)

5ccd4c4

build(deps): bump github.com/spf13/viper from 1.10.1 to 1.11.0 (#1054)

7509903

Context block height fix on TraceTx (#1051)

bc4b018

eth_getBlockByNumber fix on batch transactions (#1050)

7e35906

fix: tests/solidity/package.json to reduce vulnerabilities (#1036)

e7b6d92

The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-ANSIREGEX-1583908 Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

fix: tests/solidity/suites/storage/package.json to reduce vulnerabili…

d96e2b7

…ties (#1039) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NODEFETCH-2342118 Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

fix: tests/solidity/suites/eip1559/package.json to reduce vulnerabili…

e4abbe1

…ties (#1038) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NODEFETCH-2342118 Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

rpc: make json-rpc API namespaces extensible (#1056)

0543a28

* make jsonrpc api namespaces extensible Closes: #1052, #1037 * Apply suggestions from code review Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

docs: update EVM spec

a121224

fix: update BaseFee JSON-RPC (#1059)

0f09964

* release: v0.14.0 changelog (#1057) * fix: update BaseFee JSON-RPC * typo * changelog

build(deps): bump github.com/btcsuite/btcd from 0.22.0-beta to 0.22.1…

fb13fd4

… (#1069)

fix!: london hardfork check logic in json-rpc apis (#1068)

556c2cc

0xmuralik added 2 commits January 5, 2023 10:39

fix upgrade

ded812f

remove TxFeeChecker

be3d3b7

0xmuralik self-assigned this Jan 5, 2023

github-actions bot added C:CLI C:Crypto C:Proto C:Types Type: Build Type: CI Type: Docs Type: Tests labels Jan 5, 2023

0xmuralik changed the title ~~Upgrade cosmos to v0.46.7~~ Sync fork Jan 5, 2023

0xmuralik changed the title ~~Sync fork~~ Sync from fork Jan 5, 2023

0xmuralik added 2 commits January 6, 2023 11:24

fix lint errors

c729fb7

remove super linter

59c7c4a

0xmuralik added 5 commits January 6, 2023 12:25

nix open issue remove integration test

7c5a9bf

semgrep fix

0214c5c

ignore semgrep

aafde24

remove semgrep ignore

60afa02

run godmod2nix locally and ignore lint check

b5ebfbb

0xmuralik marked this pull request as ready for review January 6, 2023 10:49

0xmuralik requested review from i-norden and roysc January 6, 2023 10:49

0xmuralik added 2 commits January 9, 2023 13:05

Merge branch 'main' into murali/update-fork

40e455f

fix lint error

51aa603

i-norden approved these changes Jan 9, 2023

View reviewed changes

0xmuralik merged commit cb104e0 into main Jan 10, 2023

zramsay mentioned this pull request Mar 17, 2023

Investigate non-deterministic test failures in testutil/network/network.go #104

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sync from fork #74

Sync from fork #74

0xmuralik commented Jan 5, 2023

codecov-commenter commented Jan 6, 2023 •

edited

Loading

0xmuralik commented Jan 6, 2023

i-norden left a comment •

edited

Loading

Sync from fork #74

Sync from fork #74

Conversation

0xmuralik commented Jan 5, 2023

Description

codecov-commenter commented Jan 6, 2023 • edited Loading

Codecov Report

0xmuralik commented Jan 6, 2023

i-norden left a comment • edited Loading

Choose a reason for hiding this comment

codecov-commenter commented Jan 6, 2023 •

edited

Loading

i-norden left a comment •

edited

Loading