This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Allow overriding health endpoint check in handler #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rghetia
reviewed
Sep 26, 2019
…le test TestIgnoreHealthEndpoints, and add cases
…ub.com:tjcelaya/opencensus-go into feature/ochttp-handler-custom-health-endpoints
rghetia
reviewed
Sep 30, 2019
plugin/ochttp/server.go
Outdated
| // incoming HTTP request should be considered a health check. This is in | ||
| // addition to the private isHealthEndpoint func which may also indicate | ||
| // tracing should be skipped. | ||
| IsHealthEndpoint func(string) bool |
There was a problem hiding this comment.
Description looks good now.
It might be better to pass http.Request rather than just Path. For example, decision could be made on a header.
There was a problem hiding this comment.
Makes perfect sense since the other funcs also accept the http.Request, I feel silly for not having considered it sooner. Thanks for the suggestion!
rghetia
approved these changes
Oct 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1171 by allowing users to supply a
func (string) boolwhich can be used to determine if the path is a health-check, falling back to the existing solution if no func is supplied.Test copied from
TestIgnoreHealthzto supply the new parameter but I'd be happy to merge them or modify the cases.