This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Don't include ParentSpanId when zero #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ParentSpanId field of tracepb.Span must be empty for the root span.
bogdandrutu
reviewed
Oct 6, 2019
| @@ -38,10 +38,14 @@ func ocSpanToProtoSpan(sd *trace.SpanData) *tracepb.Span { | |||
| if sd.Name != "" { | |||
| namePtr = &tracepb.TruncatableString{Value: sd.Name} | |||
| } | |||
| var parentSpanID []byte | |||
| if sd.ParentSpanID != (trace.SpanID{}) { | |||
There was a problem hiding this comment.
Not sure why this needs to be fixed here and not in the Jaeger gRPC exporter in the collector.
There was a problem hiding this comment.
The field is documented as “If this is a root span, then this field must be empty.“ which it currently isn’t, so this is definitely a bug in this repo IMO. The Jaeger gRPC exporter could work around it, but it is following the documentation and this bug could easily cause problems with other systems. It is also a really trivial fix.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ParentSpanId field of tracepb.Span must be empty for the root span.
This causes issues when combined with opentelemetry-collector and the jaeger gRPC exporter.