Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

Send files and report as a single e-mail #1579

Closed
ngosset opened this issue Feb 26, 2020 · 4 comments · Fixed by #1628
Closed

Send files and report as a single e-mail #1579

ngosset opened this issue Feb 26, 2020 · 4 comments · Fixed by #1628

Comments

@ngosset
Copy link
Contributor

ngosset commented Feb 26, 2020

Summary

Files are sent as a separate e-mail. This is a problem as files can come in out of order and it's not clear which report they are from. We should try to send everything as one e-mail.

Motivation

This is also important because an offensive image could be received by the analyst before they see the report that has a warning image might be offensive

Unresolved questions

Additionally: Can we make the warning about potential offensive image more apparent (bigger font or part of the subject?)

@ngosset ngosset added technical debt need for launch Cannot go live without this labels Feb 26, 2020
@sastels
Copy link
Contributor

sastels commented Feb 27, 2020

It’s unlikely this will be done by Monday - what about if we just don’t send files that fail CM?

@davidheerema
Copy link
Contributor

If we / @kevinyang06 can complete a PR for adding a subject to emails, the emails themselves can say "attachment for report number x" or something like that which could protect analysts that way.

At this point, whatever is simplest for Monday.

@davidheerema
Copy link
Contributor

I don't think sending emails as a single email is need for launch, but adding a subject or not sending files that are CM should be...

Right now I don't know (forget) if the attachment names themselves even match what the report email lists them as.

@sastels sastels added high priority and removed need for launch Cannot go live without this labels Feb 28, 2020
@sastels
Copy link
Contributor

sastels commented Feb 28, 2020

Given that we are adding appropriate subjects to the emails, do we still need a single email? if so, shoulod it be a lower priority? @ngosset

@sastels sastels mentioned this issue Mar 5, 2020
3 tasks
@sastels sastels self-assigned this Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants