Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace getters with properties #1441

Closed
5 of 8 tasks
YodaEmbedding opened this issue Mar 17, 2023 · 1 comment
Closed
5 of 8 tasks

Replace getters with properties #1441

YodaEmbedding opened this issue Mar 17, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed wontfix This will not be worked on

Comments

@YodaEmbedding
Copy link

YodaEmbedding commented Mar 17, 2023

🚀 Feature Request

IRunner contains get_* methods, and Runner implements these, but also exposes *. For instance,

runner.get_model() == runner.model

It might be clearer to have a single Python-esque property, e.g., runner.model.

Motivation

Clarity.

Proposal

It might be clearer to have a single Python-esque property, e.g., runner.model.

Also, some way to set e.g. .model, .loaders, .engine, etc without running runner.train(), which initializes private variants of the above (e.g. ._model), and then calls runner.run(), which runs on_experiment_start, which then finally initializes .model.

Alternatives

N/A

Additional context

N/A

Checklist

  • feature proposal description
  • motivation
  • extra proposal context / proposal alternatives review

FAQ

Please review the FAQ before submitting an issue:

@YodaEmbedding YodaEmbedding added enhancement New feature or request help wanted Extra attention is needed labels Mar 17, 2023
@stale
Copy link

stale bot commented May 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 21, 2023
@stale stale bot closed this as completed Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants