Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding duo T5 #127

Merged
merged 6 commits into from
Dec 11, 2020
Merged

Adding duo T5 #127

merged 6 commits into from
Dec 11, 2020

Conversation

wiltan-uw
Copy link
Contributor

MS MARCO Passage subset run results:

top 10

2020-12-09 17:21:20 [INFO] evaluate_passage_ranker: precision@1 0.29524
2020-12-09 17:21:20 [INFO] evaluate_passage_ranker: recall@3 0.46508
2020-12-09 17:21:20 [INFO] evaluate_passage_ranker: recall@50 0.80635
2020-12-09 17:21:20 [INFO] evaluate_passage_ranker: recall@1000 0.84762
2020-12-09 17:21:20 [INFO] evaluate_passage_ranker: mrr 0.42082
2020-12-09 17:21:20 [INFO] evaluate_passage_ranker: mrr@10 0.41392

#####################
MRR @10: 0.4139229024943311
QueriesRanked: 105
#####################

top 50

2020-12-09 16:26:07 [INFO] evaluate_passage_ranker: precision@1 0.29524
2020-12-09 16:26:07 [INFO] evaluate_passage_ranker: recall@3 0.46508
2020-12-09 16:26:07 [INFO] evaluate_passage_ranker: recall@50 0.80635
2020-12-09 16:26:07 [INFO] evaluate_passage_ranker: recall@1000 0.84762
2020-12-09 16:26:07 [INFO] evaluate_passage_ranker: mrr 0.41811
2020-12-09 16:26:07 [INFO] evaluate_passage_ranker: mrr@10 0.40882

#####################
MRR @10: 0.40882086167800463
QueriesRanked: 105
#####################

@ronakice ronakice self-requested a review December 9, 2020 19:42
Copy link
Member

@ronakice ronakice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay minus a few things this is great stuff! Thanks for adding it :)

pygaggle/rerank/transformer.py Outdated Show resolved Hide resolved
pygaggle/run/evaluate_passage_ranker.py Outdated Show resolved Hide resolved
pygaggle/run/evaluate_passage_ranker.py Outdated Show resolved Hide resolved
@ronakice
Copy link
Member

ronakice commented Dec 9, 2020

It will be nice to run this on the entire set on Compute Canada for various mono_hits and also figure out how to cache mono results if available instead of running the entire pipeline multiple times, but these can be addressed in future PRs!

@ronakice
Copy link
Member

ronakice commented Dec 9, 2020

Replicated in Colab!

Copy link
Member

@ronakice ronakice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@rodrigonogueira4 rodrigonogueira4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ronakice
Copy link
Member

Great! Merging

@ronakice ronakice merged commit d20334a into castorini:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants