Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement methods for shim scripts #18809

Closed
vitorgalvao opened this issue Feb 13, 2016 · 9 comments
Closed

Implement methods for shim scripts #18809

vitorgalvao opened this issue Feb 13, 2016 · 9 comments
Labels
core Issue with Homebrew itself rather than with a specific cask. discussion enhancement outdated stale Issue which has not received any feedback for some time.

Comments

@vitorgalvao
Copy link
Member

@caskroom/maintainers This replaces #9203. Everyone agrees shim scripts are desirable, so lets allow them.

On a first phase, if anyone submits a cask that employs a shim script (usually inside a preflight and using ruby methods to write to a file), we should (after determining it is indeed necessary and we have no other way to fix the problem) accept it and add a comment mentioning it’s a shim (this will allow us to find them easier to study/replace).

On a second phase (the point of this issue), we should implement something to make those easier to make. So, two points:

  • Should we really implement something to make them easier, or should we just accept them in their usual rough form (has the advantage of not encouraging them, which is good since they should be used as a last resort)?
  • Any suggestions for implementations/interface?
@vitorgalvao vitorgalvao added enhancement discussion core Issue with Homebrew itself rather than with a specific cask. labels Feb 13, 2016
@adidalal
Copy link
Contributor

@vitorgalvao
Copy link
Member Author

#15876 doesn’t apply, because the shim isn’t necessary (the tool officially creates the necessary script).

@psibre
Copy link
Contributor

psibre commented Feb 13, 2016

@vitorgalvao thanks for the heads up and for quickly merging #18827 -- I'll see if I can contribute a test and shim script

@psibre
Copy link
Contributor

psibre commented Feb 13, 2016

A thought occurs: is it even possible to add some sort of test to ensure that the shim script works correctly? I'm thinking of something along the lines of the test block in homebrew formulas...

@vitorgalvao
Copy link
Member Author

@psibre No, we don’t have anything like that. Shim scripts should be discouraged, though (and only used in specific situations). This is not really related to this issue at hand (this issue is about deciding on an interface for shim scripts), so I ask that you open a new issue for further questions (every caskroom mantainer is likely getting an email to each reply to this issue, so we should really stay on topic).

@adidalal
Copy link
Contributor

What's the official comment for a shim script?

@vitorgalvao
Copy link
Member Author

What's the official comment for a shim script?

I guess # shim script (https://github.com/caskroom/homebrew-cask/issues/18809) is OK.

@stale
Copy link

stale bot commented Feb 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Issue which has not received any feedback for some time. label Feb 7, 2019
@vitorgalvao vitorgalvao removed the stale Issue which has not received any feedback for some time. label Feb 8, 2019
@stale
Copy link

stale bot commented Mar 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Issue which has not received any feedback for some time. label Mar 1, 2019
@stale stale bot closed this as completed Mar 8, 2019
@lock lock bot added the outdated label Apr 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core Issue with Homebrew itself rather than with a specific cask. discussion enhancement outdated stale Issue which has not received any feedback for some time.
Projects
None yet
Development

No branches or pull requests

3 participants