Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of different pixels when verifying text shadows on different OSs #311

Open
TWiStErRob opened this issue Nov 8, 2021 · 4 comments
Open

Comments

@TWiStErRob
Copy link
Contributor

TWiStErRob commented Nov 8, 2021

image
Notice that background image rendering is clearly the same, it's only the text shadows.

The two runs are from local machine and GitHub actions.

GHA (readme says Zulu)

      - uses: actions/setup-java@v1
        with:
          java-version: 11

Local

openjdk 11.0.2 2019-01-15
OpenJDK Runtime Environment 18.9 (build 11.0.2+9)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.2+9, mixed mode)

or

openjdk version "11.0.13" 2021-10-19 LTS
OpenJDK Runtime Environment Zulu11.52+13-CA (build 11.0.13+8-LTS)
OpenJDK 64-Bit Server VM Zulu11.52+13-CA (build 11.0.13+8-LTS, mixed mode)

I'm running on Windows, while GHA is Ubuntu.

Feel free to close this, if you think it's not fixable, just wanted to let you know.
We have a multiplatform team at work, so I guess it might come up for others too.

@jrodbx
Copy link
Collaborator

jrodbx commented Nov 24, 2021

Yea, I've noticed this as well, but haven't dug in much yet. Some ideas:

  1. Slight difference in JDK vendor or version (doubtful since native rendering, but worth checking)
  2. Image encoding/scaling gives different results on machines?

@TWiStErRob
Copy link
Contributor Author

@yschimke
Copy link
Contributor

yschimke commented Oct 9, 2022

Got hit by this as well. Is there any advice on the best combinations across OSX for local development and Linux for CI?

Are newer JDKs better or worse for consistency?

@borsini
Copy link

borsini commented Oct 9, 2022

@yschimke as a temporary solution we ended up generating the screenshots only on the CI, then pushing them in a new commit on our PRs. This ensures that screenshots are always the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants