Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README.md to Python3 #219

Merged
merged 2 commits into from
Apr 3, 2015
Merged

Updated README.md to Python3 #219

merged 2 commits into from
Apr 3, 2015

Conversation

aa-dit-yuh
Copy link

Changing $ sudo python to $ sudo python3 at all places should suffice.
Please review.

@rgaiacs
Copy link

rgaiacs commented Mar 7, 2015

@narayanaditya95 you should use python3 instead of python3.4.

@aa-dit-yuh aa-dit-yuh changed the title Updated README.md to Python3.4 Updated README.md to Python3 Mar 7, 2015
@aa-dit-yuh
Copy link
Author

Changes made. Please review.

@wking
Copy link
Contributor

wking commented Mar 7, 2015

On Sat, Mar 07, 2015 at 08:02:44AM -0800, Aditya Narayan wrote:

Changes made. Please review.

I'd rather just mention “Python 3” in the text. For example:

To get started:

  1. Install Python 3
    1. Install amy's Python dependencies:

      $ python -m pip install --user -r requirements.txt

Because on my Gentoo box ‘python’ is the name for the Python 3 binary:

$ python --version
Python 3.4.2

If we really want, we could say something like:

2. Install amy's Python dependencies:

   $ python -m pip install --user -r requirements.txt

 The name of your Python 3 executable may be `python3`, in which
 case run:

   $ python3 -m pip install --user -r requirements.txt

 and make similar replacements in this file's other `python`
 commands as well as in the `Makefile`.

Because we're currently hard-coding python in the Makefile.

I also prefer a --user install here than suggesting folks sudo install
system packages, since system-wide installs are best left to your
system's package manager (in my opinion ;), and we shouldn't claim to
need root privileges if we don't need them.

@aa-dit-yuh
Copy link
Author

@wking
Refering to a wiki at Ubuntu, it seems python always points to Python2.7, if installed. Although there are goals to shift everything to Python3 as mentioned in the wiki, it still hasn't materialised. I am aware that other distro may point python to Python3.
Using python instead of python3 does not solve the problem for me, unless I add an alias at my .bashrc.
I suggest we explicitly mention python3 in the Makefile for the same reason.

Please correct me if I am wrong.

@rgaiacs
Copy link

rgaiacs commented Mar 8, 2015 via email

@wking
Copy link
Contributor

wking commented Mar 8, 2015

On Sat, Mar 07, 2015 at 04:42:47PM -0800, Aditya Narayan wrote:

Refering to a wiki at Ubuntu…

The wiki links to PEP 394 1, which suggests ‘python3’ too, so I'll
reverse my position and support ‘python’ → ‘python3’. This PR should
update the Makefile too.

@aa-dit-yuh
Copy link
Author

Sorry for missing out the Makefile. Updated Makefile as instructed.

@wking
Copy link
Contributor

wking commented Mar 9, 2015

On Sun, Mar 08, 2015 at 05:23:14PM -0700, Aditya Narayan wrote:

Updated Makefile as instructed.

Thanks :). The PR looks good to me now.

@pbanaszkiewicz
Copy link
Contributor

These changes look good to me so I'll go ahead and merge them.

pbanaszkiewicz added a commit that referenced this pull request Apr 3, 2015
@pbanaszkiewicz pbanaszkiewicz merged commit 7f8d6c6 into carpentries:master Apr 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants