Re-enable cilium when upgrading #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
approved these changes
Sep 2, 2019
There was a problem hiding this comment.
If the socket is missing, then the daemon is likely not running. Is there any chance that some daemon logs from Cilium could be floating around somewhere after upgrade?
Also worth verifying that it's not just stuck pulling a new container image because the imagePullPolicy is set to Always (rather than what it should be, IfNotPresent).
One minor comment below but otherwise looks good.
snap/hooks/configure
Outdated
| @@ -302,3 +302,9 @@ then | |||
| systemctl restart snap.${SNAP_NAME}.daemon-apiserver | |||
| fi | |||
|
|
|||
| if [ -f "${SNAP_DATA}/bin/cilium" ] | |||
There was a problem hiding this comment.
Does this need to be -L? That's what the disable script uses:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joestringer the cilium addon will not upgrade as expected. To see what happens deploy microk8s from beta enable some addons and cilium and then upgrade refresh to edge:
The cilium socket seems to be missing, but I was not able to revive it in an "elegant" way.
This PR will detect if cilium is enabled and and then force a re-enabling/re-installation. Not that pretty but I believe it works.
As this blocks our release cycle (failing upgrades will stop any new releases) I would like to merge it soon and perhaps do a proper fix at a later stage based on your feedback. Many thanks.