Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure nf_conntrack module loaded for kubelite. #4705

Merged
merged 1 commit into from
Oct 23, 2024

Commits on Oct 16, 2024

  1. fix: ensure nf_conntrack module loaded for kubelite.

    This patch ensures that the `nf_conntrack` kernel module is loaded
    before `kubelite` is started as the ProxyServer needs to read some
    conntrack module-related params from procfs.
    
    Previously, although the it would always crashed if the module wasn't
    loaded, this wasn't that common of an occurrence in practice as there
    are quite a few ways `nf_conntrack` gets loaded transparently:
    * Cilium [automatically loads `iptable_nat`](https://github.com/cilium/cilium/blob/63cd391f93b4e2c865268241d384504348672042/pkg/datapath/iptables/iptables.go#L367-L368)
    after a small startup delay, whose dependency tree includes `nf_conntrack`
    * starting firewalld/ufw/most other firewall services
    * setting iptables/nftables rules which imply session tracking
    
    By explicitly loading `nf_conntrack` before starting `kubelite`,
    it should ensure the procfs values ther ProxyServer reads are
    always present on startup.
    
    Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
    aznashwan committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    58b3dbb View commit details
    Browse the repository at this point in the history