-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Migrate maas-ui from CRA to Vite #5207
Conversation
Demo starting at https://maas-ui-5207.demos.haus |
i am a numpty sometimes
I've finally created a successful build check! |
OK, I'll update and remove run-dotrun from merge requirements for now. |
@ndv99 Running
We should refactor both |
Fixed! |
There's a bunch of warnings around the basename when running tests: We're also getting a virsh memoised selector error on this PR which does not seem to happen on main (it might just be that it only surfaced now that we changed the build pipeline, but still worth investigating).
|
I've seen both of these - the first one, I'm fairly confident can be fixed pretty easily by setting "base" to "/" in vite.config.ts, but the second one I'm much less sure about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @ndv99 👏
This is ready to go to main. Let's monitor for any issues closely in the following days.
Thank you so much! |
This PR is work in progress, and will break a lot of things.
Done
process.env
withimport.meta.env
REACT_
in env vars withVITE_
To do
Update GitHub and Usabilla env var keysQA steps
Fixes
Fixes:
Screenshots
Notes