Disable default k8s services for AMI #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HomayoonAlimohammadi
approved these changes
Oct 15, 2024
eaudetcobello
approved these changes
Oct 15, 2024
eaudetcobello
pushed a commit
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Disable k8s services on new default AMI.
Rationale
The CAPA provider was broken because of a cloud-init issue. See kubernetes-sigs/cluster-api-provider-aws#5115. Upstream implemented a temporary workaround to pin the cloud-init version kubernetes-sigs/image-builder#1590.
We can now use the new AMI from upstream. This image contains kubelet and containerd by default so we need to disable them before bootstrapping the
k8s-snap.A permanent solution is worked out here: kubernetes-sigs/image-builder#1583. Once this is done, we need to start build our own AMIs as part of our release workflow to provide supported AMIs for each release. We already have a card to work on this.
I also slightly changed the template variables to have defaults instead of just suggestions. IMHO it is weird to need to copy all those values. Now, only the values one wants to change need to be touched.