Remove unused code, comments and update errors to use fmt.Errorf #67
Conversation
| @@ -51,6 +46,7 @@ func (r *MachineReconciler) SetupWithManager(ctx context.Context, mgr ctrl.Manag | |||
|
|
|||
| // +kubebuilder:rbac:groups=cluster.x-k8s.io,resources=clusters;clusters/status,verbs=get;list;watch | |||
| // +kubebuilder:rbac:groups=cluster.x-k8s.io,resources=machines;machines/status,verbs=get;list;watch;create;update;patch;delete | |||
|
|
|||
There was a problem hiding this comment.
I remember that having or not having this space caused issues in the past.
Does this fixes the issue or introduces one?
There was a problem hiding this comment.
Not having a space causes the issue as the comments are treated as function docs/comments. Seems like we already have these roles in the contolplane controller so this wasn't caught. Additionally the machine controller is no-op here as it used to handle etcd removal logic, AFAIK we could also remove it totally.
| // so that the cluster does not lock and cause the cluster to go down. In the case of k8s-dqlite, this is automatically handled by the | ||
| // go-dqlite layer, and Canonical Kubernetes has logic to automatically keep a quorum of nodes in normal operation. | ||
| // | ||
| // Therefore, we currently disable this check for simplicity, but should remember that we need this precondition before proceeing. |
There was a problem hiding this comment.
Hm, this note sounds not like a waste of space tbh
There was a problem hiding this comment.
I've removed it since it referred to the commented out code later on, instead I've updated to say we've removed this check.
Removes unused etcd related commented out logic, conditions and variables
Updated errors to use
fmt.Errorf("foo: %w", err)Drop
github.com/pkg/errorssince standard library is enough for error wrapping currently