Initial version for k8sd-proxy #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neoaggelos
reviewed
Jun 7, 2024
Initial implementation of bootstrap and controlplane providers
bschimke95
reviewed
Jun 13, 2024
There was a problem hiding this comment.
Great work Berkay.
I just went through the code to understand what is going on and comment on some code style. I leave the LGTM to Angelos.
One question: I see where the k8sd-proxy pod spec is generated but I couldn't find where it is actually deployed? Is this TBD or could you point me to the code?
.github/workflows/sync-images.yaml
Outdated
| name: Sync upstream images to ghcr.io | ||
|
|
||
| on: | ||
| workflow_dispatch: |
There was a problem hiding this comment.
this should probably also be done on push: main, or as part of a cron-job?
There was a problem hiding this comment.
I've tried to stick to what we have in k8s-snap repo.
neoaggelos
reviewed
Jun 13, 2024
berkayoz
force-pushed
the
KU-959/k8sd-proxy
branch
from
d0282c2
to
5402034
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds k8s-proxy daemonset for talking to k8sd api
Adds a generator for getting clients that proxy through the proxy pods like
kubectl port-forward