-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial version for k8sd-proxy #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work to start with, left some comments
Initial implementation of bootstrap and controlplane providers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Berkay.
I just went through the code to understand what is going on and comment on some code style. I leave the LGTM to Angelos.
One question: I see where the k8sd-proxy pod spec is generated but I couldn't find where it is actually deployed? Is this TBD or could you point me to the code?
.github/workflows/sync-images.yaml
Outdated
name: Sync upstream images to ghcr.io | ||
|
||
on: | ||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should probably also be done on push: main
, or as part of a cron-job?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to stick to what we have in k8s-snap
repo.
d0282c2
to
5402034
Compare
Adds k8s-proxy daemonset for talking to k8sd api
Adds a generator for getting clients that proxy through the proxy pods like
kubectl port-forward