only pass env. vars in script step

canonical · Sep 6, 2024 · ee04a23 · ee04a23
1 parent cdee3ec
commit ee04a23
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/.github/workflows/e2e-deleteme.yaml b/.github/workflows/e2e-deleteme.yaml
@@ -10,11 +10,6 @@ jobs:
   run-e2e-tests:
     name: Run E2E Tests
     runs-on: [self-hosted, linux, X64, jammy, large]
-    env:
-      AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-      AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
-      AWS_ACCOUNT_ID: ${{ secrets.AWS_ACCOUNT_ID }}
-      AWS_REGION: us-east-2
     strategy:
       matrix:
         ginkgo_focus:
@@ -37,4 +32,10 @@ jobs:
           sudo sysctl fs.inotify.max_user_instances=8192
       - name: Run e2e tests
         run: |
-          sudo ./hack/ci-e2e-tests.sh true aws v0.1.2
+          sudo -E ./hack/ci-e2e-tests.sh true aws v0.1.2
+        env:
+          GOPROXY: direct
+          AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+          AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+          AWS_ACCOUNT_ID: ${{ secrets.AWS_ACCOUNT_ID }}
+          AWS_REGION: us-east-2
diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml
@@ -2,8 +2,6 @@ name: E2E Tests
 
 on:
   pull_request:
-    branches:
-      - does-not-exist
 
 permissions:
   contents: read