Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable Puppet, Chef mcollective in default config #385

Merged
merged 2 commits into from
May 27, 2020

Conversation

igalic
Copy link
Collaborator

@igalic igalic commented May 23, 2020

these config management things work on BSD, they also claim to work on all distros, so enabling them!

ref: https://bugs.launchpad.net/cloud-init/+bug/1880279

@OddBloke
Copy link
Collaborator

Thanks Mina! I have no objection to this change, it seems like the right thing to do. If there are issues with the config modules then we can address those. I do have one outstanding concern though: if these modules are so broken on *BSD that they traceback during in their default behaviour, then this will regress boot on *BSD. Can you confirm that you've successfully booted a BSD image with these modules reenabled?

@igalic
Copy link
Collaborator Author

igalic commented May 25, 2020

without configuration so far:

2020-05-25 18:52:39,004 - stages.py[DEBUG]: Running module puppet (<module 'cloudinit.config.cc_puppet' from '/usr/local/lib/python3.7/site-packages/cloudinit/config/cc_puppet.py'>) with frequency once-per-instance
2020-05-25 18:52:39,004 - handlers.py[DEBUG]: start: modules-final/config-puppet: running config-puppet with frequency once-per-instance
2020-05-25 18:52:39,004 - util.py[DEBUG]: Writing to /var/lib/cloud/instances/5824445/sem/config_puppet - wb: [644] 26 bytes
2020-05-25 18:52:39,004 - helpers.py[DEBUG]: Running config-puppet using lock (<FileLock using file '/var/lib/cloud/instances/5824445/sem/config_puppet'>)
2020-05-25 18:52:39,005 - cc_puppet.py[DEBUG]: Skipping module named puppet, no 'puppet' configuration found
2020-05-25 18:52:39,005 - handlers.py[DEBUG]: finish: modules-final/config-puppet: SUCCESS: config-puppet ran successfully
2020-05-25 18:52:39,005 - stages.py[DEBUG]: Running module chef (<module 'cloudinit.config.cc_chef' from '/usr/local/lib/python3.7/site-packages/cloudinit/config/cc_chef.py'>) with frequency once-per-instance
2020-05-25 18:52:39,005 - handlers.py[DEBUG]: start: modules-final/config-chef: running config-chef with frequency once-per-instance
2020-05-25 18:52:39,005 - util.py[DEBUG]: Writing to /var/lib/cloud/instances/5824445/sem/config_chef - wb: [644] 26 bytes
2020-05-25 18:52:39,006 - helpers.py[DEBUG]: Running config-chef using lock (<FileLock using file '/var/lib/cloud/instances/5824445/sem/config_chef'>)
2020-05-25 18:52:39,006 - cc_chef.py[DEBUG]: Skipping module named chef, no 'chef' key in configuration
2020-05-25 18:52:39,006 - handlers.py[DEBUG]: finish: modules-final/config-chef: SUCCESS: config-chef ran successfully
2020-05-25 18:52:39,006 - stages.py[DEBUG]: Running module mcollective (<module 'cloudinit.config.cc_mcollective' from '/usr/local/lib/python3.7/site-packages/cloudinit/config/cc_mcollective.py'>) with frequency once-per-instance
2020-05-25 18:52:39,006 - handlers.py[DEBUG]: start: modules-final/config-mcollective: running config-mcollective with frequency once-per-instance
2020-05-25 18:52:39,006 - util.py[DEBUG]: Writing to /var/lib/cloud/instances/5824445/sem/config_mcollective - wb: [644] 26 bytes
2020-05-25 18:52:39,007 - helpers.py[DEBUG]: Running config-mcollective using lock (<FileLock using file '/var/lib/cloud/instances/5824445/sem/config_mcollective'>)
2020-05-25 18:52:39,007 - cc_mcollective.py[DEBUG]: Skipping module named mcollective, no 'mcollective' key in configuration
2020-05-25 18:52:39,007 - handlers.py[DEBUG]: finish: modules-final/config-mcollective: SUCCESS: config-mcollective ran successfully

these config management things work on BSD, they also claim to work on all distros, so enabling them!

ref: https://bugs.launchpad.net/cloud-init/+bug/1880279
@raharper
Copy link
Collaborator

Hrm, Travis shows green but it's "waiting for status here"
https://travis-ci.org/github/canonical/cloud-init/builds/691054573

Copy link
Collaborator

@raharper raharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@igalic igalic closed this May 27, 2020
@igalic igalic reopened this May 27, 2020
@raharper raharper merged commit 8377897 into canonical:master May 27, 2020
@igalic igalic deleted the patch-1 branch May 27, 2020 21:15
@blackboxsw blackboxsw mentioned this pull request May 29, 2020
This was referenced May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants