HACKING.rst: introduce .net -> Networking refactor section #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For ease of review, the rendered version of |
raharper
approved these changes
May 22, 2020
igalic
approved these changes
May 23, 2020
|
Given that we've agreed on this as a basis going forward, I actually think it makes sense to land this in-tree so that we can more easily discuss required amendments to it as I do the initial implementation. I've marked it as ready for review, and should be able to land it (with Ryan's review) once CI passes. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was looking at the initial implementation for this refactor, I realised that we didn't actually have a concrete description of the proposed refactor (and process). To save people from having to Just Know (TM), this introduces a section to
HACKING.mdnamedOngoing Refactorsas well as its first entry, for this refactor.I do not intend this to be merged before I have an initial implementation (hence "Draft"), but figured that I may as well push this up for review while I'm working on that.