-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(BSD) util.py:boottime: make finding libc platform independent #366
Conversation
@goneri finally getting around to fixing this! |
and slower. and since we're making it slower, let's cache it, in case boottime gets called more than once.
I know it's not called on Linux (so I won't block merge on this at all, in particular because it's broken on Linux in master), but do we expect I see:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mina! This LGTM, but I'll wait for a +1 from @goneri (or I'll just go ahead without on Monday, in case they're busy) before I Approve and land it.
anyone planning to make QNX available in their cloud? but anyway, we should add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's Monday, you know what that means.
and slower.
and since we're making it slower, let's cache it, in case boottime gets
called more than once.
this should fix
boottime()
(again).