BSD: upgrade support #305
Merged
BSD: upgrade support #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goneri
force-pushed
the
bsd-upgrade-support
branch
from
aebc703
to
8831228
Compare
goneri
force-pushed
the
bsd-upgrade-support
branch
from
8831228
to
8d80749
Compare
blackboxsw
requested changes
Apr 14, 2020
goneri
force-pushed
the
bsd-upgrade-support
branch
from
8d80749
to
545095d
Compare
|
Thanks for the review @blackboxsw. |
blackboxsw
reviewed
Apr 24, 2020
blackboxsw
requested changes
Apr 24, 2020
goneri
force-pushed
the
bsd-upgrade-support
branch
from
545095d
to
a23842c
Compare
blackboxsw
requested changes
May 4, 2020
|
|
||
| distro = cloudinit.distros.netbsd.NetBSD("netbsd", cfg, None) | ||
| expectation = ['pkgin', '-y', 'full-upgrade'] if with_pkgin else None | ||
| assert distro.pkg_cmd_upgrade_prefix == expectation |
There was a problem hiding this comment.
Excellent, can we add an assert about what if being checked by os.path.exists
Suggested change
| assert distro.pkg_cmd_upgrade_prefix == expectation | |
| assert distro.pkg_cmd_upgrade_prefix == expectation | |
| assert [mock.call('/usr/pkg/bin/pkgin')] == m_os.path.exists.call_args_list |
Implement the upgrade support: - FreeBSD: using `pkg upgrade` - NetBSD: with `pkgin`
goneri
force-pushed
the
bsd-upgrade-support
branch
from
a23842c
to
4ed1e49
Compare
This was referenced May 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the upgrade support:
pkg upgradepkgin