-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BSD: upgrade support #305
BSD: upgrade support #305
Conversation
aebc703
to
8831228
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix this issue
8831228
to
8d80749
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor nits to get clarity. Thanks again.
8d80749
to
545095d
Compare
Thanks for the review @blackboxsw. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the unit tests here, if possible, please align them with our new coding style suggestion for pytest.
545095d
to
a23842c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 with a minor nit on the unit test and a rebase against master. Then we'll land it.
thanks again!
|
||
distro = cloudinit.distros.netbsd.NetBSD("netbsd", cfg, None) | ||
expectation = ['pkgin', '-y', 'full-upgrade'] if with_pkgin else None | ||
assert distro.pkg_cmd_upgrade_prefix == expectation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, can we add an assert about what if being checked by os.path.exists
assert distro.pkg_cmd_upgrade_prefix == expectation | |
assert distro.pkg_cmd_upgrade_prefix == expectation | |
assert [mock.call('/usr/pkg/bin/pkgin')] == m_os.path.exists.call_args_list |
Implement the upgrade support: - FreeBSD: using `pkg upgrade` - NetBSD: with `pkgin`
a23842c
to
4ed1e49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bring it home
Implement the upgrade support:
pkg upgrade
pkgin