Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Right Chevron SCSS (Upstreamed in Vanilla 4.12.0) #1269

Closed
jmuzina opened this issue Jun 6, 2024 · 2 comments · Fixed by #1309
Closed

Remove Right Chevron SCSS (Upstreamed in Vanilla 4.12.0) #1269

jmuzina opened this issue Jun 6, 2024 · 2 comments · Fixed by #1309

Comments

@jmuzina
Copy link
Member

jmuzina commented Jun 6, 2024

c.com is creating its own right chevron style here:

.p-icon--chevron-right {
@extend .p-icon--chevron-up;
transform: rotate(-90deg);
}

However as of Vanilla 4.12.0, this class has been upstreamed. This style can be removed after updating Vanilla to 4.12.0.

The career progression page also uses left and right chevrons in the carousel:

.p-careers-progression-carousel__previous {
@extend .p-icon--chevron-up;
border: 0;
height: 44px;
transform: rotate(90deg);
width: 44px;
}
.p-careers-progression-carousel__next {
@extend .p-icon--chevron-up;
border: 0;
height: 44px;
// Fix rotation spacing
margin-top: 2%;
transform: rotate(-90deg);
width: 44px;
}

The transform:rotate rules can be removed from p-careers-progression-carousel__previous and p-careers-progression-carousel__next, and those styles should now extend .p-icon--chevron-left and .p-icon--chevron-right, respectively.

@britneywwc
Copy link
Contributor

Hi @jmuzina, is this still blocked by Vanilla?

@jmuzina
Copy link
Member Author

jmuzina commented Jul 22, 2024

Hi @britneywwc ! No, this is in Vanilla now and is not blocked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants