Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SIM Swap & SIM Swap notification subscription yaml to make the '+' mandatory for phoneNumber #100

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

bigludo7
Copy link
Collaborator

@bigludo7 bigludo7 commented Apr 3, 2024

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Alignement with Commonalities
Update SIM Swap & SIM Swap notification subscriptionyaml to make the '+' mandatory for phoneNumber

Which issue(s) this PR fixes:

Fixes #85

Special notes for reviewers:

Changelog input

 release-note
- Mandate '+' for phoneNumber

Additional documentation

This section can be blank.

docs

@bigludo7 bigludo7 changed the title Update SIM Swap yaml to make the '+' mandatory for phoneNumber Update SIM Swap & SIM Swap notification subscription yaml to make the '+' mandatory for phoneNumber Apr 3, 2024
Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fernandopradocabrillo fernandopradocabrillo merged commit 7b885e4 into main Apr 3, 2024
@bigludo7 bigludo7 deleted the bigludo7-patch-4 branch April 3, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PhoneNumber pattern - clarification on optional "+" prefix
2 participants