Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused messages object in SessionInfo schema #312

Conversation

sfnuser
Copy link
Collaborator

@sfnuser sfnuser commented Jun 28, 2024

What type of PR is this?

  • correction

What this PR does / why we need it:

  • Remove unused messages object in the SessionInfo schema

Which issue(s) this PR fixes:

Fixes #309

Special notes for reviewers:

As discussed in today's call

Changelog input

Removed unused `messages` object in the `SessionInfo` schema

Copy link
Collaborator

@RandyLevensalor RandyLevensalor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxl2287
Copy link
Collaborator

LGTM

@hdamker
Copy link
Collaborator

hdamker commented Jul 1, 2024

@camaraproject/quality-on-demand_maintainers I don't expect any objections, but suppose we can wait two working days before we merge (so until eod Tuesday July 2nd).

@maxl2287
Copy link
Collaborator

maxl2287 commented Jul 3, 2024

@hdamker I guess we can merge. I do not expect now any turn-around.

@hdamker hdamker merged commit fb9bfdc into camaraproject:main Jul 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Purpose of messages array in SessionInfo schema is undocumented
5 participants