Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add X-Correlator and other fixes #283

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

jlurien
Copy link
Collaborator

@jlurien jlurien commented Apr 17, 2024

What type of PR is this?

  • correction

What this PR does / why we need it:

  • Add x-correlator to all requests and responses
  • Added some missing descriptions to silent linting warnings
  • Remove weird use of allOf for example

Which issue(s) this PR fixes:

Fixes #271
Fixes #282

Changelog input

- Added x-correlator header to requests and responses

- Add x-correlator to all requests and responses
- Added some missing descriptions to silent linting warnings
- Remove weird use of allOf for example
Copy link

linux-foundation-easycla bot commented Apr 17, 2024

CLA Not Signed

Trailing spaces
@eric-murray
Copy link
Collaborator

Parameter name in the Design Guidelines is X-Correlator. I think the YAML should be consistent with the guidelines.

@jlurien
Copy link
Collaborator Author

jlurien commented Apr 25, 2024

Parameter name in the Design Guidelines is X-Correlator. I think the YAML should be consistent with the guidelines.

Yes, situation is that almost all CAMARA APIs are specifying x-correlator in lower case, so we either fix the guidelines or fix all the specs. I will raise this in Commonalities:

camaraproject/Commonalities#191

@hdamker
Copy link
Collaborator

hdamker commented Apr 26, 2024

Yes, situation is that almost all CAMARA APIs are specifying x-correlator in lower case, so we either fix the guidelines or fix all the specs.

We shouldn't wait with the merge of the PR until this is decided in Commonalities, as that will block the work on the planned API split. Therefore my proposal: we go here with lower case x-correlator (it's only "wip") but adding a new issue that we have to observe the outcome of camaraproject/Commonalities#191 and, if the decision there will be for upper case have to adapt.

@eric-murray @RandyLevensalor: if that makes sense for you, please approve the PR.

The second point, about "Missing CLA Authorisation": CAMARA Board has decided to postpone the EasyCLA introduction at least until the next board meeting. Therefore I asked @wrathwolf to deactivate the check also for our repository for the time being.

@hdamker hdamker merged commit fb33d5e into camaraproject:main Apr 26, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants