Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace link into main branch of Identity and Consent Management within "Authorization and authentication" text template #186

Conversation

hdamker
Copy link
Collaborator

@hdamker hdamker commented Jul 31, 2024

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

See #185, updating the first paragraph of the mandatory text for all APIs

Which issue(s) this PR fixes:

Will only partly fix #185, readme update will be within #181

Special notes for reviewers:

I consider this correction as essential for the rc.2

Changelog input

Replaced link into main branch of Identity and Consent Management within "Authorization and authentication" text template

@hdamker hdamker requested review from a team July 31, 2024 10:05
@jpengar
Copy link
Collaborator

jpengar commented Jul 31, 2024

@hdamker To fix #185, we would need another PR to update the README file as requested. We may do this as part of #181.

@hdamker
Copy link
Collaborator Author

hdamker commented Jul 31, 2024

@hdamker To fix #185, we would need another PR to update the README file as requested. We may do this as part of #181.

Yes, I'm working already on suggestion on #181. Have updated the description above.

Copy link
Collaborator

@jpengar jpengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdamker hdamker mentioned this pull request Jul 31, 2024
@jpengar
Copy link
Collaborator

jpengar commented Jul 31, 2024

@AxelNennker @sebdewet @tanjadegroot If it's okay with you, I can merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link within mandatory text for all APIs points to main branch - need to be corrected in rc.2
4 participants