Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup model #59

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Cleanup model #59

merged 1 commit into from
Jun 30, 2023

Conversation

patrice-conil
Copy link
Contributor

What type of PR is this?

  • cleanup

What this PR does / why we need it:

  • manage inheritance in Event models and derived classes
  • rename classes to respect naming rules (class name in CamelCase)
  • reorder object declaration to help generators (see allOf directives for inheritance)

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

@patrice-conil patrice-conil changed the base branch from main to bigludo7-patch-2 June 28, 2023 15:03
bigludo7
bigludo7 approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me !

@bigludo7 bigludo7 merged commit 9df6641 into camaraproject:bigludo7-patch-2 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigludo7 bigludo7 bigludo7 approved these changes

@eric-murray eric-murray Awaiting requested review from eric-murray

@sachinvodafone sachinvodafone Awaiting requested review from sachinvodafone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrice-conil @bigludo7