Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly indicate use of RFC3339 for DateTime attributes #55

Merged

Conversation

patrice-conil
Copy link
Collaborator

What type of PR is this?

  • documentation

What this PR does / why we need it:

Explicitly indicate use of RFC3339 for DateTime attributes

Which issue(s) this PR fixes:

Fixes #14

Special notes for reviewers:

Fix the issue with PR 19 from @bigludo7

Changelog input

Explicitly indicate use of RFC3339 for DateTime attributes
fix #14

Additional documentation

This section can be blank.

docs

@patrice-conil patrice-conil changed the title Patice conil patch datetime Explicitly indicate use of RFC3339 for DateTime attributes Aug 29, 2023
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
@rartych rartych self-requested a review September 4, 2023 13:31
Copy link
Collaborator

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jordonezlucena jordonezlucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-murray
Copy link
Collaborator

Agreement is to merge

@patrice-conil patrice-conil merged commit 318c467 into camaraproject:main Sep 7, 2023
patrice-conil added a commit to patrice-conil/Commonalities that referenced this pull request Sep 18, 2023
…ject#55.

Fix camaraproject#62
Signed-off-by: Patrice Conil <patrice.conil@orange.com>

Signed-off-by: Patrice Conil <patrice.conil@orange.com>
rartych added a commit that referenced this pull request Sep 18, 2023
Re-integrate content from #22 due to revert in #55.
@patrice-conil patrice-conil deleted the patice-conil-patch-datetime branch December 4, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explictly indicate in guideline that datetime use UTC
5 participants