Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API-Testing-Guidelines.md #281

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

Kevsy
Copy link
Collaborator

@Kevsy Kevsy commented Aug 9, 2024

line 105: changed boilerplate to kebab-case to match examples

What type of PR is this?

Add one of the following kinds:

  • documentation

What this PR does / why we need it:

This PR changes the boilerplate for the .feature filename from snake_case (file_name) to kebab-case (file-name) because all subsequent examples are written in kebab-case.

Which issue(s) this PR fixes:

Fixes #280

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

line 105: changed boilerplate to kebab-case to match examples
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve on behalf of @patrice-conil for Orange team

Copy link
Collaborator

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@rartych rartych merged commit eefe95c into camaraproject:main Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API-Testing-Guidelines: boiler plate for .feature file name in wrong case
6 participants