-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 422 UNIDENTIFIABLE_DEVICE error in API-design-guidelines.md table #256
Add 422 UNIDENTIFIABLE_DEVICE error in API-design-guidelines.md table #256
Conversation
Alignment of table in section 6.2 with Annex A.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In addition it would good to add it also to artifacts/CAMARA_common.yaml for consistency. |
UNIDENTIFIABLE_DEVICE added to table in 6.1
Err 422 UNIDENTIFIABLE_DEVICE added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes good to manage this also in the Service Exceptions Table.
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some editorials for aligment.
Also 422 code can be referenced in table of section 3.2
https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#32-http-response-codes
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Alignment of table in section 6.2 with Annex A.
Which issue(s) this PR fixes:
Fixes #249
Special notes for reviewers:
To be included in RC.2
Changelog input
Additional documentation