Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 422 UNIDENTIFIABLE_DEVICE error in API-design-guidelines.md table #256

Merged
merged 7 commits into from
Aug 2, 2024

Conversation

rartych
Copy link
Collaborator

@rartych rartych commented Jul 22, 2024

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Alignment of table in section 6.2 with Annex A.

Which issue(s) this PR fixes:

Fixes #249

Special notes for reviewers:

To be included in RC.2

Changelog input

 422 UNIDENTIFIABLE_DEVICE error added to API-design-guidelines.md table in section 6.2

Additional documentation

Alignment of table in section 6.2 with Annex A.
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

patrice-conil
patrice-conil previously approved these changes Jul 24, 2024
Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdamker
Copy link
Collaborator

hdamker commented Jul 26, 2024

@rartych #249 is mentioning "Section 6.1 and to the table in Section 6.2" but here in the PR it is only added to 6.2. By intention?

@hdamker
Copy link
Collaborator

hdamker commented Jul 26, 2024

In addition it would good to add it also to artifacts/CAMARA_common.yaml for consistency.

UNIDENTIFIABLE_DEVICE added to table in 6.1
Err 422 UNIDENTIFIABLE_DEVICE added
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good to manage this also in the Service Exceptions Table.

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some editorials for aligment.

Also 422 code can be referenced in table of section 3.2
https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#32-http-response-codes

documentation/API-design-guidelines.md Outdated Show resolved Hide resolved
artifacts/CAMARA_common.yaml Outdated Show resolved Hide resolved
documentation/API-design-guidelines.md Outdated Show resolved Hide resolved
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
patrice-conil
patrice-conil previously approved these changes Jul 31, 2024
Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hdamker
hdamker previously approved these changes Jul 31, 2024
@rartych rartych dismissed stale reviews from hdamker and patrice-conil via fa74f2a July 31, 2024 13:59
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@shilpa-padgaonkar shilpa-padgaonkar merged commit 73c194a into camaraproject:main Aug 2, 2024
@hdamker hdamker mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 422 UNIDENTIFIABLE_DEVICE error in Service Exceptions table (§6.1)
6 participants