Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reformat tables, grammar and style issues in documentation-files #234

Conversation

maxl2287
Copy link
Contributor

@maxl2287 maxl2287 commented Jun 11, 2024

What type of PR is this?

Add one of the following kinds:

  • cleanup

What this PR does / why we need it:

This PR is a fixing of some style and reference-issues

Which issue(s) this PR fixes:

Fixes #232

@maxl2287 maxl2287 changed the title fix: reformat tables, grammar and style in documentation-files reformat tables, grammar and style in documentation-files Jun 11, 2024
@maxl2287 maxl2287 changed the title reformat tables, grammar and style in documentation-files reformat tables, grammar and style issues in documentation-files Jun 11, 2024
patrice-conil
patrice-conil previously approved these changes Jun 12, 2024
Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not good enough in English to judge these subtle changes so LGTM

PedroDiez
PedroDiez previously approved these changes Jun 18, 2024
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

LGTM in advance

documentation/Linting-rules.md Outdated Show resolved Hide resolved
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
@maxl2287 maxl2287 dismissed stale reviews from PedroDiez and patrice-conil via 169ebe2 June 18, 2024 20:52
…rmat-tables-styles-grammars-in-mds

# Conflicts:
#	documentation/API-Readiness-Checklist.md
#	documentation/API-Testing-Guidelines.md
@maxl2287
Copy link
Contributor Author

@PedroDiez updated your typo-hint and resolve the merge conflicts.
Please review again :)

Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments regarding API testing guidelines

documentation/API-Testing-Guidelines.md Outdated Show resolved Hide resolved
documentation/API-Testing-Guidelines.md Outdated Show resolved Hide resolved
maxl2287 and others added 2 commits June 19, 2024 13:46
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
PedroDiez
PedroDiez previously approved these changes Jun 19, 2024
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

patrice-conil
patrice-conil previously approved these changes Jun 20, 2024
Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…rmat-tables-styles-grammars-in-mds

# Conflicts:
#	documentation/Camara_Versioning_Guidelines.md
@maxl2287 maxl2287 dismissed stale reviews from patrice-conil and PedroDiez via 40c8899 July 1, 2024 13:08
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych
Copy link
Collaborator

rartych commented Jul 2, 2024

Merging as commonly approved (the last commits resolved conficts)

@rartych rartych merged commit d045672 into camaraproject:main Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fixing typos and other style-issues in documentation-files
4 participants