Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate API-Readiness-Checklist.md #220

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

rartych
Copy link
Collaborator

@rartych rartych commented Jun 3, 2024

What type of PR is this?

  • documentation

What this PR does / why we need it:

The API-Readiness-Checklist.md is replaced by the new updated version which is located in the Release Management project.
It should be approved after merging camaraproject/ReleaseManagement#29 .

Which issue(s) this PR fixes:

Fixes #202

Special notes for reviewers:

I am not aware of references to the current API Readiness Checklist from other Commonalities documents.
Using Markdown strikeout formatting breaks table rendering, it may be clearer to keep the original table without strikeout.

Changelog input

The API-Readiness-Checklist.md is marked as deprecated

Additional documentation

@rartych rartych changed the title Update API-Readiness-Checklist.md Deprecate API-Readiness-Checklist.md Jun 3, 2024
documentation/API-Readiness-Checklist.md Outdated Show resolved Hide resolved
documentation/API-Readiness-Checklist.md Outdated Show resolved Hide resolved
@rartych rartych marked this pull request as ready for review June 11, 2024 09:07
PedroDiez
PedroDiez previously approved these changes Jun 11, 2024
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The old content was removed
@rartych
Copy link
Collaborator Author

rartych commented Jun 12, 2024

I have removed the old content (table).

@rartych rartych requested a review from PedroDiez June 12, 2024 14:51
PedroDiez
PedroDiez previously approved these changes Jun 12, 2024
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Shilpa Padgaonkar <77152136+shilpa-padgaonkar@users.noreply.github.com>
Copy link
Collaborator

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych
Copy link
Collaborator Author

rartych commented Jun 14, 2024

@patrice-conil Could you approve also this PR?

Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych merged commit 99ae98d into camaraproject:main Jun 17, 2024
@rartych rartych deleted the api-readiness-deprecation branch July 22, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate API-Readiness-Checklist.md
4 participants